Changes to support NumPy 2.0 #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use np.lib.NumpyVersion to account for change in namespace of some functions. Replaced import from numpy.core with import from numpy main namespace, where appropriate. Replace np.longcomplex with np.clongdouble. Fixed import of NumPy C-API in _pydfti extension. This follows https://numpy.org/devdocs/reference/c-api/array.html#including-and-importing-the-c-api Separate translation units, like mklfft.c, need to include arrayobject.h after defining NO_IMPORT_ARRAY preprocessor variable. The extension must be compiled with PY_ARRAY_UNIQUE_SYMBOL set to artibrary value, but same for all translation units.
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
from
7caf4a2 to
656cbf7
Compare
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
5 times, most recently
from
b18ee3f to
48d716b
Compare
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
from
48d716b to
53e8995
Compare
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
8 times, most recently
from
b8e6795 to
7d6eacb
Compare
…elease NumPy for pip builds
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
from
7d6eacb to
4430933
Compare
antonwolfy
reviewed
May 27, 2024
oleksandr-pavlyk
force-pushed
the
support-numpy-2
branch
from
ff142de to
bbdef36
Compare
|
Thanks @antonwolfy , I have applied suggested hanges |
antonwolfy
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support NumPy 2.0
Use np.lib.NumpyVersion to account for change in namespace of some functions. Replaced import from numpy.core with import from numpy main namespace, where appropriate.
Replace np.longcomplex with np.clongdouble.
Fixed import of NumPy C-API in _pydfti extension. This follows https://numpy.org/devdocs/reference/c-api/array.html#including-and-importing-the-c-api
Separate translation units, like mklfft.c, need to include arrayobject.h after defining NO_IMPORT_ARRAY preprocessor variable. The extension must be compiled with PY_ARRAY_UNIQUE_SYMBOL set to artibrary value, but same for all translation units.