Skip to content

Implement dpnp.isin #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Implement dpnp.isin #2595

wants to merge 8 commits into from
+211 −1

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Sep 25, 2025

This PR leverages the recently-added dpctl.tensor.isin to implement dpnp.isin

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2595/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_9 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2025 •
edited
Loading

Coverage Status

coverage: 81.453% (+0.006%) from 81.447%
when pulling 02dd391 on reuse-tensor-isin
into 131c490 on master.

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Oct 7, 2025
antonwolfy
antonwolfy reviewed Oct 9, 2025
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 4 times, most recently from 07f280b to 7d29652 Compare November 20, 2025 03:16
@ndgrigorian ndgrigorian marked this pull request as ready for review November 20, 2025 04:32
antonwolfy
antonwolfy reviewed Nov 20, 2025
View reviewed changes
@ndgrigorian ndgrigorian force-pushed the reuse-tensor-isin branch 3 times, most recently from 3200677 to 77d5512 Compare November 21, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy