Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit set of the API version used in conformance testing #2350

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Explicit set of the API version used in conformance testing #2350

merged 7 commits into from
Mar 26, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 27, 2025 •
edited
Loading

This PR proposes to define the API version used during testing explicitly (and to set it to 2024.12).
The tests relating to advanced indexing are failing now due to known limitation in dpctl, so it is proposed to temporary disable them with a proper comment.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 72.152%. remained the same
when pulling f9be79f on specify-array-api-version
into e0b7932 on master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_51 ran successfully.
Passed: 1197
Failed: 0
Skipped: 14

@antonwolfy antonwolfy changed the title Add a way to specify the API version to use when testing Explicit set of the API version used in conformance testing Mar 18, 2025
@antonwolfy antonwolfy marked this pull request as ready for review March 26, 2025 10:22
@antonwolfy antonwolfy merged commit d5617de into master Mar 26, 2025
68 checks passed
@antonwolfy antonwolfy deleted the specify-array-api-version branch March 26, 2025 11:54
github-actions bot added a commit that referenced this pull request Mar 26, 2025
@github-actions
Explicit set of the API version used in conformance testing (#2350)
7b437ee 
This PR proposes to define the API version used during testing
explicitly (and to set it to `2024.12`).
The tests relating to advanced indexing are failing now due to known
limitation in dpctl, so it is proposed to temporary disable them with a
proper comment. d5617de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vtavana