This repository was archived by the owner on May 17, 2023. It is now read-only.
Fixed HEVCe interlace in sample_encode #2669
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryermilov
requested review from
a team,
AntonGrishin and
mpushki
as code owners
dmitryermilov
force-pushed
the
ps_di
branch
2 times, most recently
from
ac8ab30 to
9593789
Compare
sample_encode h265 -i <yuv> -w 720 -h 480 -b 1500 -tff -extbrc:on Signed-off-by: Dmitry Ermilov <[email protected]>
|
Hi @dmitryermilov , why HEVCe interlace works with extbrc only? Our customers uses AVC/HEVC encoding with hardware ratecontrol including interlace cases. At this moment we are using patch for just removing this restriction. We are expecting the same behavior as for AVC. Also extbrc disabled at all in oneVPL sample, so interlace encoding is impossible there. |
Contributor
Author
|
Because HW is not aware of interlace in HEVC. Even in the spec interlace is defined as a sort of extension on top of regular HEVC progressive. That's why there's a field splitting VPP filter, BTW. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_encode h265 -i -w 720 -h 480 -b 1500 -tff -extbrc:on
Signed-off-by: Dmitry Ermilov [email protected]