feat: Support Advanced UI customization #1411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kholood-ea
reviewed
Jul 7, 2025
Comment on lines
+1508
to
+1517
| try { | ||
| Typeface typeface = Typeface.createFromAsset(getReactApplicationContext().getAssets(), "fonts/" + fileName); | ||
| return typeface; | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
how about extracting this to a new function instead of writing the same logic twice ?
kholood-ea
reviewed
Jul 7, 2025
Comment on lines
+1488
to
+1495
| try { | ||
| Typeface typeface = Typeface.create(fileName, Typeface.NORMAL); | ||
| if (typeface != null && !typeface.equals(Typeface.DEFAULT)) { | ||
| return typeface; | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
we can export this to a new function for better readability
kholood-ea
reviewed
Jul 7, 2025
Comment on lines
+179
to
+273
| if (themeConfig[@"primaryColor"]) { | ||
| NSString *colorString = themeConfig[@"primaryColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.primaryColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"backgroundColor"]) { | ||
| NSString *colorString = themeConfig[@"backgroundColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.backgroundColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"titleTextColor"]) { | ||
| NSString *colorString = themeConfig[@"titleTextColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.titleTextColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"subtitleTextColor"]) { | ||
| NSString *colorString = themeConfig[@"subtitleTextColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.subtitleTextColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"primaryTextColor"]) { | ||
| NSString *colorString = themeConfig[@"primaryTextColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.primaryTextColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"secondaryTextColor"]) { | ||
| NSString *colorString = themeConfig[@"secondaryTextColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.secondaryTextColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"callToActionTextColor"]) { | ||
| NSString *colorString = themeConfig[@"callToActionTextColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.callToActionTextColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"headerBackgroundColor"]) { | ||
| NSString *colorString = themeConfig[@"headerBackgroundColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.headerBackgroundColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"footerBackgroundColor"]) { | ||
| NSString *colorString = themeConfig[@"footerBackgroundColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.footerBackgroundColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"rowBackgroundColor"]) { | ||
| NSString *colorString = themeConfig[@"rowBackgroundColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.rowBackgroundColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"selectedRowBackgroundColor"]) { | ||
| NSString *colorString = themeConfig[@"selectedRowBackgroundColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.selectedRowBackgroundColor = color; | ||
| } | ||
| } | ||
|
|
||
| if (themeConfig[@"rowSeparatorColor"]) { | ||
| NSString *colorString = themeConfig[@"rowSeparatorColor"]; | ||
| UIColor *color = [self colorFromHexString:colorString]; | ||
| if (color) { | ||
| theme.rowSeparatorColor = color; | ||
| } | ||
| } |
There was a problem hiding this comment.
what do you think about replacing the redundant "ifs" with creating a dictionary with theme colors and corresponding setters property like so
NSDictionary<NSString *, void(^)(UIColor *)> *colorSetters = @{
@"primaryColor": ^(UIColor *color) { theme.primaryColor = color; },
@"backgroundColor": ^(UIColor *color) { theme.backgroundColor = color; },
....
};
then loop on them something looks like so
for (NSString *key in colorSetters) {
void (^setter)(UIColor *) = colorSetters[key];
NSString *hexString = themeConfig[key];
if ([hexString isKindOfClass:[NSString class]]) {
UIColor *color = [self colorFromHexString:hexString];
if (color) {
setter(color);
}
}
}
kholood-ea
reviewed
Jul 7, 2025
Comment on lines
+277
to
+283
| NSString *fontName = themeConfig[@"primaryFontPath"]; | ||
| NSString *fileName = [fontName lastPathComponent]; | ||
| NSString *nameWithoutExtension = [fileName stringByDeletingPathExtension]; | ||
| UIFont *font = [UIFont fontWithName:nameWithoutExtension size:17.0]; | ||
| if (font) { | ||
| theme.primaryTextFont = font; | ||
| } |
There was a problem hiding this comment.
we can also replace redundant logic for setting fonts with create one function and call it for all of them
|
Great effort @AyaMahmoud148 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review