feat: add proactive bug reporting #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: add support for newer gradle versions (#512) * feat: attach w3c header (#481) * feat: add android feature flag * fix: test cases * fix: test cases * fix: test cases * fix: test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * fix: add more test cases * Release: v14.0.0 (#532) * chore(android): bump sdk to v14.0.0 * chore(ios): bump sdk to v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * Release: v14.0.0 * chore: change release date (#535) * Release: 14.1.0 (#539) * release: 14.1.0 * release: 14.1.0 * release: v14.1.0 * release: v14.1.0 --------- Co-authored-by: kholood <[email protected]>
# Conflicts: # CHANGELOG.md # example/ios/Podfile.lock
ahmedAlaaInstabug
requested review from
kholood-ea,
MoKamall,
AndrewAminInstabug and
AyaMahmoud148
AndrewAminInstabug
previously approved these changes
Mar 13, 2025
kholood-ea
reviewed
Mar 14, 2025
| } | ||
|
|
||
| // Builder class for ProactiveReportingConfigs | ||
| class ProactiveReportingConfigsBuilder { |
There was a problem hiding this comment.
would you please tell me why have we opted into Builder pattern here instead of named parameters with default value?
MoKamall
reviewed
Mar 16, 2025
|
|
||
| @Override | ||
| public void setProactiveReportingConfigurations(@NonNull Boolean enabled, @NonNull Long gapBetweenModals, @NonNull Long modalDelayAfterDetection) { | ||
| ThreadManager.runOnMainThread(new Runnable() { |
There was a problem hiding this comment.
Could you please explain to me why are we explicitly running our logic using the ThreadManager.runOnMainThread(...) api?
| public void testSetProactiveReportingConfigurations() { | ||
| // given | ||
| boolean enabled = true; | ||
| long gapBetweekDialogs = 20; |
There was a problem hiding this comment.
I believe there's a small typo here. It should be gapBetweenDialogs instead of gapBetweekDialogs, right?
…to feat/proactive-bug-reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
feat: add proactive bug reporting
Type of change
Related issues
JIRA ID : MOB-17931
Checklists
Development
Code review