Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: automatically send a slack message for new releases #557

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

ci: automatically send a slack message for new releases #557

wants to merge 35 commits into from

Conversation

MoKamall
Copy link
Collaborator

@MoKamall MoKamall commented Mar 5, 2025 •
edited
Loading

Description of the change

Send Slack messages automatically upon releasing new versions of the SDK.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://instabug.atlassian.net/browse/MOB-17130

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@MoKamall MoKamall changed the base branch from master to dev March 5, 2025 00:53
@InstabugCI
Copy link
Collaborator

InstabugCI commented Mar 5, 2025 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 84.0% ✅

Generated by 🚫 dangerJS against f690c32

MoKamall added 22 commits March 5, 2025 03:12
@MoKamall
fix: add checkout step before notification command
6560e32
@MoKamall
fix: correct case-sensitive naming for .sh script
0fdeb5d
@MoKamall
fix: grant correct run permissions to all scripts in .scripts/*
0c74b84
@MoKamall
fix: change curl command format, change jq selector name to match cur…
1ec3dcd 
…rent job
@MoKamall
fix: retrieve workflow ID dynamically from circleci
628b019
@MoKamall
ci: add debugging prints in get_job_approver.sh
c305b35
@MoKamall
ci: add more debugging statements
8a3a583
@MoKamall
ci: change curl command format for retrieving user
21e9de3
@MoKamall
chore: test get_release_notes script alone
174c0d2
@MoKamall
chore: remove comments from message block
18a0bcf
@MoKamall
chore: test get_sdk_version script alone
16d38eb
@MoKamall
fix: add another block to the message body
80f7ee2
@MoKamall
chore: test get_job_approver script alone
5c7c935
@MoKamall
ci: disable verbose logging for curl commands
fa720ff
@MoKamall
chore: add some clean-up logic to json outputs
571759f
@MoKamall
ci: change slack job environment to macos
6fc314c
@MoKamall
ci: add install jq to job
0e4581b
@MoKamall
chore: enable debug mode for slack job
62ec228
@MoKamall
chore: remove all inner echo statements and switch to here-string (<<…
a58b0a1 
…<) operator
@MoKamall
chore: change slack job environment back to default, test get_release…
5cf8b87 
…_notes
@MoKamall
fix: add a shebang on top of the changelog_to_slack_formatter script
5149eae
@MoKamall
chore: enable debug mode for slack/notify, add shebang on top of get_…
587ca72 
…release_notes
@MoKamall MoKamall self-assigned this Mar 9, 2025
@MoKamall MoKamall marked this pull request as ready for review March 9, 2025 02:51
AndrewAminInstabug
AndrewAminInstabug reviewed Mar 9, 2025
View reviewed changes
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoKamall Great effort ... Could you take a look at the jobs that failed in the CI?

ahmedAlaaInstabug
ahmedAlaaInstabug reviewed Mar 9, 2025
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wowie! good job 👏 👏 .
could you check my comments and the CI failed tasks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedAlaaInstabug ahmedAlaaInstabug ahmedAlaaInstabug approved these changes

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

Assignees

@MoKamall MoKamall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MoKamall @InstabugCI @kholood-ea @ahmedAlaaInstabug @AndrewAminInstabug