feat: auto mask in Flutter #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedAlaaInstabug
changed the base branch from
refactor/monorepo
to
feat/user-step
ahmedAlaaInstabug
changed the title
ahmedAlaaInstabug
requested review from
kholood-ea,
a7medev,
MoKamall,
AndrewAminInstabug and
AyaMahmoud148
and removed request for
a7medev
packages/instabug_flutter/android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
Outdated
Show resolved
Hide resolved
...instabug_flutter/android/src/main/java/com/instabug/flutter/modules/InstabugPrivateView.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Add the new step to the list | ||
| _steps.add(route); | ||
| Future<dynamic>.delayed(const Duration(milliseconds: 1000), () { | ||
| // If this route is in the array, report it and remove it from the list | ||
| if (_steps.contains(route)) { |
There was a problem hiding this comment.
@ahmedAlaaInstabug Won't the condition _steps.contains(route) always evaluate to true since _steps.add(route) is executed beforehand?
| bool light = true; | ||
| double _scale = 1.0; // Initial scale of the image | ||
|
|
||
| TextEditingController _controller2 = TextEditingController(); |
There was a problem hiding this comment.
Could you rename and dispose of this controller?
| ) | ||
| : const Center(child: CircularProgressIndicator()), | ||
| ), | ||
| const SizedBox(height: 24), |
There was a problem hiding this comment.
Do we need these multiple SizedBox widgets ?
| return renderObject.paintBounds.shift(globalOffset); | ||
| } | ||
|
|
||
| // The is the same implementation used in RenderBox.localToGlobal (a subclass of RenderObject) |
There was a problem hiding this comment.
@ahmedAlaaInstabug Could you mark this class as @internal and adjust its methods to either private or @internal, depending on their calling scope, since it involves highly sensitive logic?
There was a problem hiding this comment.
Unable to locate unit tests for PrivateViewsManager.I.addAutoMasking and InstabugWidget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
feat: enhance private views
Type of change
Related issues
Jira iD : MOB-17833
Checklists
Development
Code review