ci: bump kubectl rollout-status timeout 180s → 300s - #35
Merged
Conversation
…Timeout
Closes SEC-PROV finding (audit wave 2026-05-29): NewDedicatedProvider used
`&http.Client{}` with NO timeout for the Neon Management API path. A hung
Neon connection would wedge the provisioning gRPC handler (and any caller
— worker storage tick, regrader) indefinitely, piling up goroutines until
OOM.
NeonBackend already bounds its client at neonHTTPTimeout (30s); the
DedicatedProvider path was an oversight in the same family.
Fix: 1-line — set Timeout on the &http.Client literal. Reuses the existing
constant so any future tuning lands in one place.
Production LOC delta: 1 functional + 5 comment lines.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Today's api #198 deploy timed out at 180s even though the new ReplicaSet came up healthy (rollout actually took ~240s on a fresh node with a cold image pull). Provisioner has the same pattern. Bumping to 300s removes the false-failure rerun cycle. Same change ships simultaneously in api + worker deploy.yml. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Today's api PR #198 (CORS fix) deploy timed out at 180s even though the new ReplicaSet came up healthy. The rollout actually took ~240s on a fresh node with a cold image pull. The job exited red, prod was correct, and the false-failure forced a manual rerun.
Provisioner has the same pattern.
What
Surface (rule 22)
Same change shipping simultaneously in:
Coverage (rule 17)
YAML-only, no binary change. CI itself is the gate. No Go diff.
Sites found: 3 (api, worker, provisioner)
Sites touched: 3