STYLE: Use conventional const notation

As recommended by the CppCoreGuidelines: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rl-const Place `const` qualifier before type name to be consistent across the toolkit. Conventional notation is more familiar to more programmers.
InsightSoftwareConsortium · Dec 5, 2024 · a2f9cb4 · a2f9cb4
1 parent 645a0cd
commit a2f9cb4
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/.clang-format b/.clang-format
@@ -219,7 +219,14 @@ PenaltyIndentedWhitespace: 0
 PenaltyReturnTypeOnItsOwnLine: 200
 PointerAlignment: Middle
 PPIndentWidth:   -1
-QualifierAlignment: Leave
+QualifierAlignment: Custom
+QualifierOrder:
+  - static
+  - inline
+  - friend
+  - constexpr
+  - const
+  - type
 ReferenceAlignment: Pointer
 ReflowComments:  true
 RemoveBracesLLVM: false

diff --git a/Examples/.clang-format b/Examples/.clang-format
@@ -219,7 +219,14 @@ PenaltyIndentedWhitespace: 0
 PenaltyReturnTypeOnItsOwnLine: 200
 PointerAlignment: Middle
 PPIndentWidth:   -1
-QualifierAlignment: Leave
+QualifierAlignment: Custom
+QualifierOrder:
+  - static
+  - inline
+  - friend
+  - constexpr
+  - const
+  - type
 ReferenceAlignment: Pointer
 ReflowComments:  true
 RemoveBracesLLVM: false

diff --git a/Modules/Core/Common/test/itkSmartPointerTest.cxx b/Modules/Core/Common/test/itkSmartPointerTest.cxx
@@ -45,7 +45,7 @@ class itkTestObject
     }
   }
   inline friend std::ostream &
-  operator<<(std::ostream & os, itkTestObject const & o)
+  operator<<(std::ostream & os, const itkTestObject & o)
   {
     os << "itkTestObject " << (const void *)&o << ' ' << o.m_ReferenceCount;
     return os;

diff --git a/Modules/Registration/Common/include/itkImageToImageMetric.h b/Modules/Registration/Common/include/itkImageToImageMetric.h
@@ -373,7 +373,7 @@ class ITK_TEMPLATE_EXPORT ImageToImageMetric : public SingleValuedCostFunction
 
     ~FixedImageSamplePoint() = default;
 
-    friend inline std::ostream &
+    inline friend std::ostream &
     operator<<(std::ostream & os, const FixedImageSamplePoint & val)
     {
       os << "point: " << static_cast<typename NumericTraits<FixedImagePointType>::PrintType>(val.point) << std::endl;

diff --git a/...entation/DeformableMesh/include/itkDeformableSimplexMesh3DGradientConstraintForceFilter.h b/...entation/DeformableMesh/include/itkDeformableSimplexMesh3DGradientConstraintForceFilter.h
@@ -96,7 +96,7 @@ class ImageVoxel
     m_Value = val;
   }
 
-  friend inline std::ostream &
+  inline friend std::ostream &
   operator<<(std::ostream & os, const ImageVoxel & val)
   {
     os << "Vpos: " << val.m_Vpos << std::endl;