Misc. fixes to make packaging easier #222
Conversation
Before, both structs were being polluted with the environment variables. The way it's done now, it is no longer poluted and (in my opinion) is a bit cleaner as well.
All paths can now be set in the arguments, and are all derived from the workPath (by default: ./db). This *should* require no change from the outside users as well, a transparent change.
|
Closing due to inactivity. Feel free to re-open if you want to :) |
Including the sentinel was confusing postject. That's been moved to a different file outside the package.json. postject has also been added to the package.json, since it was being used, but was not included in the lock. Mostly for completeness.
|
Hi, sorry for the lack of response. I've been busy with uni. I don't have permission to re-open. I've worked on some of the problems you've mentioned, though, and responded to some of the resolutions you've given (including some I disagree with). |
|
Actually I'll open this under a new pull request |
This moves everything back into the db directory, and only allows the FFMPEG path to be changed. This also moves around some logic, and removes unnecessary blobs out of the distribution.
|
I am going to reopen this and close #225 to keep this discussion in one place. |
|
I'd like to also migrate over the question of the settings.json from the other pull request. I was just wondering thoughts on that. |
Could you copy paste it here thx. |
|
I'd like to start discussion for the separation of settings.json as well. |
|
Re settings.json path I agree, and it's a open issue in #177 I remember there being a few issues with a chicken and egg situation though due to how settings are applied but it's not unworkable |
|
Unfortunately I'll have to continue this tomorrow as I'm running out of time for the day. Thanks for being so active! |
|
No problem and no rush :) Thanks for contributing |
|
I'll get the settings path changed and push tomorrow at some point. I've got an idea on how to accomplish that. |
|
Lemme know when this is ready for review |
|
Oops my bad yeah It's ready for review I'll mark it as such |
This includes various miscellaneous fixes and changes as described in the issue #221. My recommendation is to not squash this pull request on merging, since the commits are detailed in every change that is done.