fix(tracing): report streaming errors to generation spans - #353
Open
fcy222fcy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a streaming LLM request fails, the Langfuse
TraceGenerationspan was still emitted with the successful-lookingstreaming_responsevalue and without error metadata. This made failed generations appear successful.This change captures
interfaces.StreamEventError, records the error on the main streaming span, and addsmetadata["error"]to the generation span. Failed streams now use explicit<error>or<redacted>response placeholders, while successful streams preserve the existingstreaming_responsebehavior.Fixes #328
Type of change
How Has This Been Tested?
The following tests and checks passed locally:
go test -count=1 ./pkg/tracinggo test -race -count=1 ./pkg/tracinggo test -count=1 ./...go test -race -count=1 ./...go vet ./pkg/tracinggolangci-lint run ./...gosec ./...gofmtandgit diff --checkThe regression tests cover both content policies, successful-stream compatibility, error metadata, and exception events on the main streaming span.
Checklist: