Skip to content

Ci improvement test#5

Open
InfernalKn1ght wants to merge 29 commits into
masterfrom
ci-improvement
Open

Ci improvement test#5
InfernalKn1ght wants to merge 29 commits into
masterfrom
ci-improvement

Conversation

@InfernalKn1ght
Copy link
Copy Markdown
Owner

No description provided.

@github-actions
Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v19.1.1) reports: 3 concern(s)
  • tools/QuestPlayer/PlayerWindow.cpp:20:10: error: [clang-diagnostic-error]

    'ui_PlayerWindow.h' file not found

       20 | #include "ui_PlayerWindow.h"
          |          ^~~~~~~~~~~~~~~~~~~
    /home/runner/work/OpenSR-Fork/OpenSR-Fork/tools/QuestPlayer/PlayerWindow.cpp:35:1: error: constructor does not initialize these fields: m_ui [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
       35 | PlayerWindow::PlayerWindow(QWidget *parent) : QMainWindow(parent), m_ui(new Ui::PlayerWindow)
          | ^
  • tools/ResourceViewer/MainWindow.cpp:21:10: error: [clang-diagnostic-error]

    'ui_MainWindow.h' file not found

       21 | #include "ui_MainWindow.h"
          |          ^~~~~~~~~~~~~~~~~
    /home/runner/work/OpenSR-Fork/OpenSR-Fork/tools/ResourceViewer/MainWindow.cpp:35:1: error: constructor does not initialize these fields: ui [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
       35 | MainWindow::MainWindow(QWidget *parent)
          | ^
  • tools/ResourceViewer/ExtractDialog.cpp:20:10: error: [clang-diagnostic-error]

    'ui_ExtractDialog.h' file not found

       20 | #include "ui_ExtractDialog.h"
          |          ^~~~~~~~~~~~~~~~~~~~
    /home/runner/work/OpenSR-Fork/OpenSR-Fork/tools/ResourceViewer/ExtractDialog.cpp:26:1: error: constructor does not initialize these fields: m_ui [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
       26 | ExtractDialog::ExtractDialog(QWidget *parent) : QDialog(parent), m_ui(new Ui::ExtractDialog), m_qrcName("resource.qrc")
          | ^

Have any feedback or feature suggestions? Share it here.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch
diff --git a/tools/QuestPlayer/PlayerWindow.cpp b/tools/QuestPlayer/PlayerWindow.cpp
index a4d9557..ebe7f38 100644
--- a/tools/QuestPlayer/PlayerWindow.cpp
+++ b/tools/QuestPlayer/PlayerWindow.cpp
@@ -122 +122 @@ void PlayerWindow::showTransition(const QString &text)
-    QLabel *b = new QLabel(tr("Next"), this);
+    QLabel *b = nullptr = new QLabel(tr("Next"), this);

Used clang-format v19.1.1

No concerns from clang-format.

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant