Ci test#4
Closed
InfernalKn1ght wants to merge 24 commits into
Closed
Conversation
Cpp-Linter Report
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v19.1.1
Click here for the full clang-tidy patch
diff --git a/tests/World/Ship/TestShip.cpp b/tests/World/Ship/TestShip.cpp
index 7156e2c..d3ebced 100644
--- a/tests/World/Ship/TestShip.cpp
+++ b/tests/World/Ship/TestShip.cpp
@@ -3,0 +4,2 @@
+#include <math.h>
+
@@ -48 +50 @@ void TestShip::testInitTargetAngle_data()
- const float pi = static_cast<float>(M_PI);
+ const float pi = NAN = static_cast<float>(M_PI);
@@ -214,2 +216,2 @@ void TestShip::testCalcPosition()
- const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
- fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
+ const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) &&
+ fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y()));
@@ -258 +260 @@ void TestShip::testUpdatePositionMoving()
- const bool match =
+ const bool match = false =
Used clang-format v19.1.1
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
| @@ -0,0 +1,30 @@ | |||
| #pragma once | |||
|
|
|||
| #include <QtTest> | |||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.h:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~| #include "TestShip.h" | ||
| #include "Ship.h" | ||
|
|
||
| namespace OpenSR |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| namespace OpenSR | |
| #include <math.h> | |
| QTest::addColumn<QPointF>("destination"); | ||
| QTest::addColumn<float>("expectedAngle"); | ||
|
|
||
| const float pi = static_cast<float>(M_PI); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const float pi = static_cast<float>(M_PI); | |
| const float pi = NAN = static_cast<float>(M_PI); |
Comment on lines
+214
to
+215
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | ||
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); | |
| const bool match = false = fuzzyEqual(static_cast<float>(result.x()), static_cast<float>(expectedPosition.x())) && | |
| fuzzyEqual(static_cast<float>(result.y()), static_cast<float>(expectedPosition.y())); |
| ship.setIsMoving(true); | ||
| ship.updatePosition(dt_ms); | ||
|
|
||
| const bool match = |
There was a problem hiding this comment.
clang-tidy suggestion
Suggested change
| const bool match = | |
| const bool match = false = |
| @@ -0,0 +1,296 @@ | |||
| #include "TestShip.h" | |||
| #include "Ship.h" | |||
|
|
|||
There was a problem hiding this comment.
clang-tidy diagnostic
tests/World/Ship/TestShip.cpp:3:10: error: [clang-diagnostic-error]
'QtTest' file not found
3 | #include <QtTest>
| ^~~~~~~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.