-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of the P Model architecture #442
Conversation
…added a few more attributes
for more information, see https://pre-commit.ci
…ollegeLondon/pyrealm into 380-replace-npallclose
…ration-guide-and-changes-doc Revise the migration guide and changes doc
…odel-documentation Revise the P Model documentation
…lose Replacing `np.allclose`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #442 +/- ##
===========================================
+ Coverage 96.27% 96.73% +0.45%
===========================================
Files 34 35 +1
Lines 2659 2661 +2
===========================================
+ Hits 2560 2574 +14
+ Misses 99 87 -12 ☔ View full report in Codecov by Sentry. |
|
||
from pyrealm.pmodel.scaler import SubdailyScaler | ||
from pyrealm.pmodel.subdaily import memory_effect | ||
from pyrealm.pmodel.acclimation import AcclimationModel | ||
|
||
# A five day time series running from noon until noon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the change in the time the comments needs adapting - it's now noon until midnight
# A five day time series running from noon until noon | |
# A five day time series running from noon until midnight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work David
Description
This PR is to bring all of the collected functionality in branch associated with the 2.0.0 meta issue (#383) down into
develop
. This:2.0.0-rc2
Important
This is a huge PR, but the commits have all been reviewed by sub-PRs onto this branch, so it is pre-reviewed.
I'll need to make some pushes into:
in order to update them to this.
This doesn't completely close down all of the child issues in #383 but we want to bank these changes now.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks