Revise the P Model documentation #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 383-meta-release-200 #441 +/- ##
=======================================================
Coverage ? 96.72%
=======================================================
Files ? 35
Lines ? 2660
Branches ? 0
=======================================================
Hits ? 2573
Misses ? 87
Partials ? 0 ☔ View full report in Codecov by Sentry. |
MarionBWeinzierl
requested changes
Feb 28, 2025
| {cite:p}`Prentice:2014bc,Wang:2017go,Stocker:2020dh`. | ||
|
|
||
| * The [subdaily P Model](subdaily_details/subdaily_overview), extends the P Model to | ||
| incorporates acclimation of photosynthetic pathways to changing environmental |
There was a problem hiding this comment.
Suggested change
| incorporates acclimation of photosynthetic pathways to changing environmental | |
| incorporate acclimation of photosynthetic pathways to changing environmental |
|
|
||
| * The relative advantages of the C3 and C4 photosynthetic pathways differ with | ||
| environmental conditions. The [C3 / C4 plant competition](c3c4model) model uses the | ||
| relative advantage to estimates the expected fraction of C4 plants in a community. |
There was a problem hiding this comment.
Suggested change
| relative advantage to estimates the expected fraction of C4 plants in a community. | |
| relative advantage to estimate the expected fraction of C4 plants in a community. |
| {cite:p}`Prentice:2014bc,Wang:2017go` along with links to further details of the core | ||
| components of the model. It may be useful to read this alongside: | ||
|
|
||
| * The [worked examples](worked_examples) of using `pyrealm` to fitting the Standard P |
There was a problem hiding this comment.
Suggested change
| * The [worked examples](worked_examples) of using `pyrealm` to fitting the Standard P | |
| * The [worked examples](worked_examples) of using `pyrealm` to fit the Standard P |
|
|
||
| The term $m_j$ is at the heart of the P model and describes the trade off between | ||
| carbon dioxide capture and water loss in photosynthesis. Given the environmental | ||
| conditions, a leaf will adjust its stomata to a value of ($\chi$) that optimises |
There was a problem hiding this comment.
Suggested change
| conditions, a leaf will adjust its stomata to a value of ($\chi$) that optimises | |
| conditions, a leaf will adjust its stomata to a value of $\chi$ that optimises |
Comment on lines
90
to
92
| this trade off. When $\chi$ is less than one, the partial pressure inside of | ||
| $\ce{CO2}$ inside the leaf is lowered and $m_j$ captures the resulting loss in light | ||
| use efficiency. |
There was a problem hiding this comment.
This sentence somehow does not seem right. Is it really "inside of CO2 inside the leaf"?
| * The form of the [Arrhenius scaling](./arrhenius) used to | ||
| calculate the electron transfer rate and carboxylation capacity at standard | ||
| temperatures. This is central to the Subdaily P Model as the variables $J_{max}$ and | ||
| $V_{cmax}$ need converted to a standard temperature to map predictions from the daily |
There was a problem hiding this comment.
Suggested change
| $V_{cmax}$ need converted to a standard temperature to map predictions from the daily | |
| $V_{cmax}$ need to be converted to a standard temperature to map predictions from the daily |
MarionBWeinzierl
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revises the contents of
source/users/pmodel:PModelandSubdailyPModelare now broken out into a new directory.pmodel_detailsandsubdaily_detailspart of the doc tree are now focussed on the specific implementations of those models.Building the docs on this PR here (jumping to a page with an embedded draw.io to check they render on RTD and they do):
https://pyrealm.readthedocs.io/en/438-revise-the-p-model-documentation/users/pmodel/pmodel_details/pmodel_overview.html
Fixes #438
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks