Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scaler.py to core #407

Closed
wants to merge 3 commits into from
Closed

Conversation

MarionBWeinzierl
Copy link
Collaborator

Description

Instead of taking just the daily means functions out of scaler, this PR moves the whole class to core, to make it functionality available elsewhere in the code.

Fixes #406

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

@MarionBWeinzierl MarionBWeinzierl self-assigned this Jan 31, 2025
@MarionBWeinzierl MarionBWeinzierl linked an issue Jan 31, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (56ccf57) to head (f4a0c91).
Report is 47 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #407      +/-   ##
===========================================
+ Coverage    96.27%   96.48%   +0.20%     
===========================================
  Files           34       35       +1     
  Lines         2659     2730      +71     
===========================================
+ Hits          2560     2634      +74     
+ Misses          99       96       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidorme
Copy link
Collaborator

Hmmm. Not sure how I feel about this.

That's partly because this is going to change with the move to an AcclimationModel API (see #394), but also I think the correct way to do this is probably to separate out the core of the wrapping and subsetting engine in here from the SubdailyPModel specific components. That's more of a job, but I guess I think that rather than moving the very SubdailyPModel specific implementation into core now it would be better to import it from its current location for the meantime. Then the usage can help guide the breaking out the underlying shared functionality into core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move daily means functions etc to core
3 participants