Skip to content

Commit

Permalink
Review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
davidorme committed Feb 27, 2025
1 parent dcd7be1 commit c5c8647
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/source/users/versions.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ used the theoretical maximum value of 1/8.
### Arrhenius scaling of $J_{max}$ and $V_{cmax}$

In 1.0.0, {class}`~pyrealm.pmodel.pmodel.PModel` used an Arrhenius relationship with a
peaked at intermediate temperatures :cite:`Kattge:2007db` to calculate $J_{max25}$ and
peak at intermediate temperatures :cite:`Kattge:2007db` to calculate $J_{max25}$ and
$V_{cmax25}$, although in practice the implementation did not exhibit the correct peaked
form. In contrast, the {class}`~pyrealm.pmodel.pmodel.SubdailyPModel` used a simple
Arrhenius scaling without a peak.

* Both classes now take the `method_arrhenius` argument to specify the form of this
scaling.
* Both class now default to using the `simple` method of Arrhenius scaling. We
* Both classes now default to using the `simple` method of Arrhenius scaling. We
**strongly** recommend the use of this method over the experimental `kattge_knorr`
method.

Expand Down Expand Up @@ -214,7 +214,7 @@ acclim_model.set_window(
half_width=np.timedelta64(1, "h"),
)
# Fit the subdaily model - which can now accepts all of the alternative method
# Fit the subdaily model - which now accepts all of the alternative method
# arguments used by the PModel class.
subdaily_model = SubdailyPModel(
env=pm_env,
Expand Down

0 comments on commit c5c8647

Please sign in to comment.