Skip to content

refactor(core): share discovery item ID prefixes - #58

Merged
IgorArkhipov merged 2 commits into
mainfrom
refactor/shared-item-ids
Aug 17, 2026
Merged

refactor(core): share discovery item ID prefixes#58
IgorArkhipov merged 2 commits into
mainfrom
refactor/shared-item-ids

Conversation

@IgorArkhipov

Copy link
Copy Markdown
Owner

Summary

  • Move discovery-item ID prefixes into a shared ids module used by both inventory construction and toggle parsing.
  • Remove duplicated Claude/Pi/OpenCode prefix literals that previously lived in both discovery.rs and mutation.rs.

Test Plan

  • cargo fmt --all -- --check
  • cargo clippy -p unpin-core --all-targets --all-features --locked -- -D warnings
  • cargo test -p unpin-core --all-features --locked --lib
  • cargo test -p unpin-core --all-features --locked --test discovery --test mutation --test provider_registry
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --all-features --locked
  • cargo run -p unpin-cli --locked -- --help
  • cargo audit --deny warnings
  • cargo machete
  • Pi/OpenCode disposable-root host validation when release-impacting
  • Full local provider matrix run and finalized when release-impacting

Safety Checklist

  • Tests and examples do not read real home-directory provider state.
  • Tests and examples do not use .env* files.
  • Write paths use dry-run planning, confirmation, backup, audit, and restore behavior where relevant.
  • Provider changes stay within the current Claude Code, Codex CLI, Cursor,
    Pi, OpenCode, and Zed support scope.
  • Public docs or examples were updated when user-facing behavior changed.

Reviewer Notes

No behavior change. Compat skill namespaces and Cursor marketplace settings keys stay in discovery; this only consolidates item ID prefixes. Independent of #57.

Not a release candidate; provider matrix and live-host validation were not run.

Made with Cursor

Keep inventory construction and toggle parsing on one set of ID
literals so a prefix change cannot silently desynchronize plan/apply.

Co-authored-by: Cursor <cursoragent@cursor.com>
@IgorArkhipov
IgorArkhipov merged commit 2b4d77d into main Aug 17, 2026
47 of 54 checks passed
@IgorArkhipov
IgorArkhipov deleted the refactor/shared-item-ids branch August 17, 2026 16:26
@IgorArkhipov IgorArkhipov mentioned this pull request Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant