refactor(core): share discovery item ID prefixes - #58
Merged
Conversation
Keep inventory construction and toggle parsing on one set of ID literals so a prefix change cannot silently desynchronize plan/apply. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idsmodule used by both inventory construction and toggle parsing.discovery.rsandmutation.rs.Test Plan
cargo fmt --all -- --checkcargo clippy -p unpin-core --all-targets --all-features --locked -- -D warningscargo test -p unpin-core --all-features --locked --libcargo test -p unpin-core --all-features --locked --test discovery --test mutation --test provider_registrycargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-features --lockedcargo run -p unpin-cli --locked -- --helpcargo audit --deny warningscargo macheteSafety Checklist
.env*files.Pi, OpenCode, and Zed support scope.
Reviewer Notes
No behavior change. Compat skill namespaces and Cursor marketplace settings keys stay in discovery; this only consolidates item ID prefixes. Independent of #57.
Not a release candidate; provider matrix and live-host validation were not run.
Made with Cursor