Skip to content

Remove deprecated modules from igniteui-react for dropdown samples #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

IMinchev64
Copy link
Contributor

No description provided.

Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target sample does not work when clicking the buttons. It throws an error

@IMinchev64 IMinchev64 requested a review from mddragnev June 3, 2025 12:49
@dkamburov dkamburov added status: verified The PR is tested and ready for a merge and removed awaiting-test labels Jun 12, 2025
@dkamburov dkamburov merged commit 9b585ae into vnext Jun 12, 2025
2 checks passed
@dkamburov dkamburov deleted the iminchev/dropdown-react-modules branch June 12, 2025 14:49
HUSSAR-mtrela added a commit that referenced this pull request Jun 17, 2025
* chore: switch to 19 alpha packages, install data-grids

* chore: sync chart toolbar data-grids module ref

* chore: sync samples grids packages deps, add data-grids

* chore: sync update react template to 19 alpha packages

* chore: manual samples data-grids package dep switch

* refactor: manual samples data-grids imports rename

* chore: manual samples 19 alpha package deps

* refactor: manual shared DataGridPager data-grids imports rename

* chore: update browser setup with data-grids and versions

* chore: sync don't emit name and auto-name for wrapped components

* refactor: manual grid samples enum casing

* refactor: remove manual samples column names

* refactor: missed filter mode enum case

* fix: data-grid samples deps and v19 event renames

* chore: maintain fixed dep versions of the samples browser app

* chore: sync generated event on prefix

* chore: sync generated event rename changes from xplat templates

* refactor: manual samples button clicked to onClick

* refactor: manual samples inputOcurred to onInput

* fix: correct event type on button click

* chore(deps): bump path-to-regexp and express in /browser

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v1.8.0...v1.9.0)

Updates `express` from 4.19.2 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-version: 1.9.0
  dependency-type: indirect
- dependency-name: express
  dependency-version: 4.21.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump axios and browser-sync in /browser

Removes [axios](https://github.com/axios/axios). It's no longer used after updating ancestor dependency [browser-sync](https://github.com/BrowserSync/browser-sync). These dependencies need to be updated together.


Removes `axios`

Updates `browser-sync` from 2.29.3 to 3.0.4
- [Release notes](https://github.com/BrowserSync/browser-sync/releases)
- [Changelog](https://github.com/BrowserSync/browser-sync/blob/master/changelog.js)
- [Commits](BrowserSync/browser-sync@v2.29.3...v3.0.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 
  dependency-type: indirect
- dependency-name: browser-sync
  dependency-version: 3.0.4
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump webpack from 5.91.0 to 5.98.0 in /browser

Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.98.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.91.0...v5.98.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump ejs from 3.1.9 to 3.1.10 in /browser

Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-version: 3.1.10
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump rollup from 2.79.1 to 2.79.2 in /browser

Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 2.79.2.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.79.1...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-version: 2.79.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump @babel/runtime from 7.24.1 to 7.27.0 in /browser

Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.1 to 7.27.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-version: 7.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: sync generated samples deps update

* chore: manual samples version bump for react/react-grids alpha 6

* chore: update browser to react/react-grids alpha.6

* chore: also bump igniteui-webcomponents to rc version since webpack is an idiot with nested deps

* refactor: manual samples rename change to onChange, adjust handlers

* refactor: remove non-existing IgrCalendarDate import and icon variant prop

* chore: sync generate samples version update

* chore: manual samples and browser bump to react/react-grids rc.0

* chore: sync generate samples version update

* chore: manual samples and browser bump to react/react-grids 19.0.1

* refactor: update tabs samples for 19, clean up

* fix(icon-button-size): set margin properly (#774)

* Pivot config to type (#776)

* fix: [MANUAL] grid pagingMode value

* chore: sync grid xplat samples remove of forceUpdate

* refactor: update Finjs sample for 19, resolve issues (#775)

* refactor: remote data operations samples update to 19 (#781)

Co-authored-by: Damyan Petev <[email protected]>

* refactor: State Persistence samples update for 19 (#782)

* refactor: Custom Context Menu sample update for 19 (#786)

* refactor: update registerIconFromText use on manual samples; small fi… (#787)

* revert: mistakenly deleted React scope import for JSX

* Remove sender from event handlers for 19 update (#788)

* Enums to union types for 19 update (#789)

* refactor: manual calendar config init objects (#790)

* Dpetev/v19 misc fixes (#799)

* mdd-update-packages

mdd-update-packages

* manual export (#804)

* Update index.tsx

* chore: package lock leftover

* chore: sync charts gen sample changes

* chore: sync grid generated changes

* chore: sync gen change restoring root grid refs for handlers logic (#808)

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.5.20.8

* feat(tooltip): add tooltip samples

* docs(tooltip): update sample titles

* Updated TextArea samples for React 19

* Update Switch samples for React19

* Update Slider topics for react 19

* chore: sync generation changes form template grids/combined remove

* refactor(grids): manual samples remove obsolete grids/combined import

* Remove keys and modules from date-time-input samples

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.5.29.2

* update

update

* mdd-add-webcomponents-package

mdd-add-webcomponents-package

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.1

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.2

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.3

* update to 19.0.0-alpha.2

* Update to latest React packages (#857)

* Update to latest React packages

* Revert igniteui-react-grids to 19.0.2

* update data annotation samples to use refs to set target axis

* refactor: Avatar samples update + adding styling sample for react v19 (#842)

* fix: Updated Stepper samples for react v19 (#847)

* Remove modules regs and make more similar to angular sample.

* Resolving comments and formatting code

* Merge pull request #843 from IgniteUI/ttonev/remote-paging-hgrid

* refactor: Disabled Summaries samples update react19 (#819)

* Remove modules and fix issue with overview sample radio check state. (#870)

* Remove module imports. (#871)

* Update badge sample to v19 (#831)

* Update button group samples to v19 (#827)

* Update button samples to v19 (#828)

* Update checkbox samples to v19 (#829)

* Update chip samples to v19 (#826)

* Merge pull request #797 from IgniteUI/iminchev/data-searching-react

Update data-searching samples for grid and tGrid for React 19

* Remove deprecated modules from igniteui-react for dropdown samples (#835)

* remove: deprecated modules for icon-button samples (#836)

* Remove deprecated modules for input samples (#838)

* Remove deprecated modules for mask-input samples (#839)

* remove: deprecated modules for radio samples (#840)

* реможе: deprecated modules for ратинг samples (#841)

* Update Ripple samples for React 19 (#832)

* Update Select samples for react 19 (#825)

* Merge pull request #849 from IgniteUI/ttonev/combo-topic-modules-removal

removed module register from combo topics since its deprecated

* Added Combo template sample (#837)

* Update card samples for React19 (#844)

* Update Carousel samples for react 19 (#846)

* remove: keys and deprecated modules from expansion panel samples (#854)

* refactor(icon): manual samples remove deprecated modules (#858)

* removed module register (#850)

* remove: keys and deprecated modules from nav-drawer samples (#861)

* Remove keys and deprecated modules from banner samples (#862)

* removed module imports from dialog samples (#868)

* Snackbar Overview sample update (#864)

* Toast samples update (#865)

* Removed module register from calendar samples (#866)

* updated date picker samples (#867)

* fix(sample): forced number conversion to avoid errors from reading th… (#731)

* refactor: Accordion samples update for react v19 (#834)

* combine multiple data sources in code-viewer

* Update package-lock.json

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Damyan Petev <[email protected]>
Co-authored-by: mddifilippo89 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bozhidara Pachilova <[email protected]>
Co-authored-by: Deyan Kamburov <[email protected]>
Co-authored-by: Mariela Tihova <[email protected]>
Co-authored-by: Tihomir Tonev <[email protected]>
Co-authored-by: tfsbuild <[email protected]>
Co-authored-by: Adrian Petrov <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
Co-authored-by: Ivan Minchev <[email protected]>
Co-authored-by: IGvaleries <[email protected]>
Co-authored-by: Andrew Goldenbaum <[email protected]>
Co-authored-by: Maya Kirova <[email protected]>
Co-authored-by: Martin Dragnev <[email protected]>
Co-authored-by: IMinchev <[email protected]>
HUSSAR-mtrela added a commit that referenced this pull request Jun 18, 2025
* chore: switch to 19 alpha packages, install data-grids

* chore: sync chart toolbar data-grids module ref

* chore: sync samples grids packages deps, add data-grids

* chore: sync update react template to 19 alpha packages

* chore: manual samples data-grids package dep switch

* refactor: manual samples data-grids imports rename

* chore: manual samples 19 alpha package deps

* refactor: manual shared DataGridPager data-grids imports rename

* chore: update browser setup with data-grids and versions

* chore: sync don't emit name and auto-name for wrapped components

* refactor: manual grid samples enum casing

* refactor: remove manual samples column names

* refactor: missed filter mode enum case

* fix: data-grid samples deps and v19 event renames

* chore: maintain fixed dep versions of the samples browser app

* chore: sync generated event on prefix

* chore: sync generated event rename changes from xplat templates

* refactor: manual samples button clicked to onClick

* refactor: manual samples inputOcurred to onInput

* fix: correct event type on button click

* chore(deps): bump path-to-regexp and express in /browser

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v1.8.0...v1.9.0)

Updates `express` from 4.19.2 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.19.2...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-version: 1.9.0
  dependency-type: indirect
- dependency-name: express
  dependency-version: 4.21.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump axios and browser-sync in /browser

Removes [axios](https://github.com/axios/axios). It's no longer used after updating ancestor dependency [browser-sync](https://github.com/BrowserSync/browser-sync). These dependencies need to be updated together.


Removes `axios`

Updates `browser-sync` from 2.29.3 to 3.0.4
- [Release notes](https://github.com/BrowserSync/browser-sync/releases)
- [Changelog](https://github.com/BrowserSync/browser-sync/blob/master/changelog.js)
- [Commits](BrowserSync/browser-sync@v2.29.3...v3.0.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-version: 
  dependency-type: indirect
- dependency-name: browser-sync
  dependency-version: 3.0.4
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump webpack from 5.91.0 to 5.98.0 in /browser

Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.98.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.91.0...v5.98.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump ejs from 3.1.9 to 3.1.10 in /browser

Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.9...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-version: 3.1.10
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump rollup from 2.79.1 to 2.79.2 in /browser

Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 2.79.2.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.79.1...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-version: 2.79.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(deps): bump @babel/runtime from 7.24.1 to 7.27.0 in /browser

Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.1 to 7.27.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-version: 7.27.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore: sync generated samples deps update

* chore: manual samples version bump for react/react-grids alpha 6

* chore: update browser to react/react-grids alpha.6

* chore: also bump igniteui-webcomponents to rc version since webpack is an idiot with nested deps

* refactor: manual samples rename change to onChange, adjust handlers

* refactor: remove non-existing IgrCalendarDate import and icon variant prop

* chore: sync generate samples version update

* chore: manual samples and browser bump to react/react-grids rc.0

* chore: sync generate samples version update

* chore: manual samples and browser bump to react/react-grids 19.0.1

* refactor: update tabs samples for 19, clean up

* fix(icon-button-size): set margin properly (#774)

* Pivot config to type (#776)

* fix: [MANUAL] grid pagingMode value

* chore: sync grid xplat samples remove of forceUpdate

* refactor: update Finjs sample for 19, resolve issues (#775)

* refactor: remote data operations samples update to 19 (#781)

Co-authored-by: Damyan Petev <[email protected]>

* refactor: State Persistence samples update for 19 (#782)

* refactor: Custom Context Menu sample update for 19 (#786)

* refactor: update registerIconFromText use on manual samples; small fi… (#787)

* revert: mistakenly deleted React scope import for JSX

* Remove sender from event handlers for 19 update (#788)

* Enums to union types for 19 update (#789)

* refactor: manual calendar config init objects (#790)

* Dpetev/v19 misc fixes (#799)

* mdd-update-packages

mdd-update-packages

* manual export (#804)

* Update index.tsx

* chore: package lock leftover

* chore: sync charts gen sample changes

* chore: sync grid generated changes

* chore: sync gen change restoring root grid refs for handlers logic (#808)

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.5.20.8

* feat(tooltip): add tooltip samples

* docs(tooltip): update sample titles

* Updated TextArea samples for React 19

* Update Switch samples for React19

* Update Slider topics for react 19

* chore: sync generation changes form template grids/combined remove

* refactor(grids): manual samples remove obsolete grids/combined import

* Remove keys and modules from date-time-input samples

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.5.29.2

* update

update

* mdd-add-webcomponents-package

mdd-add-webcomponents-package

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.1

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.2

* Adding changes from build igniteui-xplat-examples-output+PRs_2025.6.2.3

* update to 19.0.0-alpha.2

* Update to latest React packages (#857)

* Update to latest React packages

* Revert igniteui-react-grids to 19.0.2

* update data annotation samples to use refs to set target axis

* refactor: Avatar samples update + adding styling sample for react v19 (#842)

* fix: Updated Stepper samples for react v19 (#847)

* Remove modules regs and make more similar to angular sample.

* Resolving comments and formatting code

* Merge pull request #843 from IgniteUI/ttonev/remote-paging-hgrid

* refactor: Disabled Summaries samples update react19 (#819)

* Remove modules and fix issue with overview sample radio check state. (#870)

* Remove module imports. (#871)

* Update badge sample to v19 (#831)

* Update button group samples to v19 (#827)

* Update button samples to v19 (#828)

* Update checkbox samples to v19 (#829)

* Update chip samples to v19 (#826)

* Merge pull request #797 from IgniteUI/iminchev/data-searching-react

Update data-searching samples for grid and tGrid for React 19

* Remove deprecated modules from igniteui-react for dropdown samples (#835)

* remove: deprecated modules for icon-button samples (#836)

* Remove deprecated modules for input samples (#838)

* Remove deprecated modules for mask-input samples (#839)

* remove: deprecated modules for radio samples (#840)

* реможе: deprecated modules for ратинг samples (#841)

* Update Ripple samples for React 19 (#832)

* Update Select samples for react 19 (#825)

* Merge pull request #849 from IgniteUI/ttonev/combo-topic-modules-removal

removed module register from combo topics since its deprecated

* Added Combo template sample (#837)

* Update card samples for React19 (#844)

* Update Carousel samples for react 19 (#846)

* remove: keys and deprecated modules from expansion panel samples (#854)

* refactor(icon): manual samples remove deprecated modules (#858)

* removed module register (#850)

* remove: keys and deprecated modules from nav-drawer samples (#861)

* Remove keys and deprecated modules from banner samples (#862)

* removed module imports from dialog samples (#868)

* Snackbar Overview sample update (#864)

* Toast samples update (#865)

* Removed module register from calendar samples (#866)

* updated date picker samples (#867)

* fix(sample): forced number conversion to avoid errors from reading th… (#731)

* refactor: Accordion samples update for react v19 (#834)

* combine multiple data sources in code-viewer

* Update package-lock.json

* Revert "Merge branch 'master' into vnext"

This reverts commit 73f2ffa, reversing
changes made to 54f4eb2.

* resolve merge conflicts

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Damyan Petev <[email protected]>
Co-authored-by: mddifilippo89 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bozhidara Pachilova <[email protected]>
Co-authored-by: Deyan Kamburov <[email protected]>
Co-authored-by: Mariela Tihova <[email protected]>
Co-authored-by: Tihomir Tonev <[email protected]>
Co-authored-by: tfsbuild <[email protected]>
Co-authored-by: Adrian Petrov <[email protected]>
Co-authored-by: Simeon Simeonoff <[email protected]>
Co-authored-by: Ivan Minchev <[email protected]>
Co-authored-by: IGvaleries <[email protected]>
Co-authored-by: Andrew Goldenbaum <[email protected]>
Co-authored-by: Maya Kirova <[email protected]>
Co-authored-by: Martin Dragnev <[email protected]>
Co-authored-by: IMinchev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: verified The PR is tested and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants