Preserve navigation when cellEdit is cancelled and editMode is set to false - 19.2.x #16394
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonikaKirkova
added
grid: cell-editing
grid
version: 19.2.x
❌ status: awaiting-test
GrblackStar
added
✅ status: verified
GrblackStar
approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where navigation state was lost when cell editing was cancelled and editMode was asynchronously set to false. The fix ensures that focus is properly restored to the grid body when ending cell edit mode programmatically, allowing keyboard navigation to continue working as expected.
Key Changes:
- Modified
endCellEdit()to accept an optionalrestoreFocusparameter that restores focus to the grid body when true - Updated the cell's
editModesetter to passrestoreFocus: truewhen ending edit mode - Added comprehensive test coverage for the async cancellation scenario
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/src/lib/grids/common/crud.service.ts | Added restoreFocus parameter to endCellEdit() method to restore focus to grid body when ending edit mode |
| projects/igniteui-angular/src/lib/grids/grid-public-cell.ts | Updated call to endCellEdit() to pass true for restoring focus |
| projects/igniteui-angular/src/lib/grids/grid/grid-cell-editing.spec.ts | Added test case verifying navigation preservation when cell edit is cancelled and editMode is set to false asynchronously |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16262
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)