Skip to content

fix(action-strip): Assign parent to not destroy on DOM move. #16270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 20.1.x
Choose a base branch
from
Open

fix(action-strip): Assign parent to not destroy on DOM move. #16270

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5ac7a0d
fix(action-strip): Assign parent to not destroy on DOM move.
Jun 16, 2025
01683e7
chore(*): Move strip handling after parentComponentRef is populated.
Jun 16, 2025
fbd1785
fix(action-strip): Fix timing issues.
Jun 20, 2025
a8642fd
fix(igxGridRow): On destroy check for still shown action strip.
Oct 9, 2025
ec11d6d
chore(action-strip,elements): minor new lines formatting
damyanpetev Oct 10, 2025
7201841
fix(igxGrid): On detach also check for still shown action strip.
Oct 13, 2025
89b1eb8
Merge branch 'mkirova/fix-15768-20.1.x' of https://github.com/IgniteU…
Oct 13, 2025
f18b2f4
chore(*): Add null check.
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/igniteui-angular/src/lib/grids/row.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,10 @@ export class IgxRowDirective implements DoCheck, AfterViewInit, OnDestroy {
* @internal
*/
public ngOnDestroy() {
// if action strip is shown here but row is about to be destroyed, hide it.
if (this.grid.actionStrip && this.grid.actionStrip.context === this) {
this.grid.actionStrip.hide();
}
this.destroy$.next(true);
this.destroy$.complete();
}
Expand Down
Loading