chore(deps): upgrade to Next 15 + React 19, refresh safe minors - #4
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22759f8dc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| import { ThemeProvider as NextThemesProvider } from "next-themes"; | ||
| import type { ThemeProviderProps } from "next-themes/dist/types"; | ||
| import type { ThemeProviderProps } from "next-themes"; |
There was a problem hiding this comment.
Add children to the theme provider prop type
Once the upgraded React 19/@types packages are installed, next-themes@0.4.6's exported ThemeProviderProps no longer includes children, but this wrapper still destructures and renders children; npm run type-check/next build will fail with Property 'children' does not exist on type 'ThemeProviderProps'. Please wrap the imported type in React.PropsWithChildren or define an explicit children: React.ReactNode prop for this local provider.
Useful? React with 👍 / 👎.
Summary
Code Fixes Applied
src/components/providers/theme-provider.tsx: Fixed next-themes import by changing
import type { ThemeProviderProps } from "next-themes/dist/types"toimport type { ThemeProviderProps } from "next-themes"(dist/types path no longer exported in 0.4.6)src/app/error.tsx: Added eslint-disable comment above the hard-reload
<a href="/">link inside Button component (intentional hard reload that escapes render tree, requires eslint-disable-next-line @next/next/no-html-link-for-pages)Gate Results
Notes