Production hardening: ESLint, CI gate, coverage, honest LOC telemetry - #3
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the dashboard to production grade. No product behavior changes — all gates now run and pass.
What changed
.eslintrc.json,next/core-web-vitals) —npm run lintnow runs non-interactively and passes clean..github/workflows/nextjs-ci.yml): lint → type-check → coverage → build on every push/PR. Previously only Python had CI.@vitest/coverage-v8) with an enforced 80% threshold onsrc/lib/**(the logic layer).src/libwent from ~48% → 95% lines / 86% branches.api.tsclient (happy/error/network),usePolling(load/error/reschedule/refetch/disabled),useHotkey,useAnimatedNumbereasing loop, andproject.tsmetadata.package-lock.json(~11.6k) and the generatedcoverage/report (~5.7k), which would have inflated the publiclines_of_codefrom a real ~5.8k to 24.8k. Excluded lockfiles + generated dirs; refreshed the artifact to 5778 (was a stale 1390 that predated the lockfile)..env.local.example(the showcase dashboard uses no env vars); addedengines: node>=20; gitignoredcoverage/.Verification (local)
npm run lint✓ ·npm run type-check✓ ·npm run test:coverage✓ (51 tests) ·npm run build✓system: "runbook-orchestrator",mode: "showcase"still conformant to TELEMETRY_SCHEMA.md.