Accept modern rootless Terraform DOT input - #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/graphs/renderfor JSON DOT rendering with SVG, graph data, and warnings[root] rootnode/inputand/uploadresponse compatibilityRoot Cause
The frontend treated
[root] rootas a required node and dereferenced it even after labeling the graph invalid. Current Terraform versions can emit valid dependency graphs without that historical synthetic node, so pasted output was incorrectly rejected and could trigger a JavaScript error.User Impact
Users can paste or upload current
terraform graphoutput directly. Invalid, malformed, or oversized input now produces an actionable message within the graph tab instead of a reload prompt.Validation
/tmp/blast-radius-plan-venv/bin/python -m pytest -q— 17 passed, 7 subtests passed/api/graphs/render— HTTP 200, two nodesnode --check blastradius/server/static/js/blast-radius.jsgit diff --check main...HEADCompatibility
/input,/upload,/graph.svg, and/graph.jsonremain available. Legacy form routes retain theirSVG/JSONresponse keys; the new API uses lowercase typed fields and an object-shapedgraphvalue.Fixes #45