Skip to content

Fixed GitHub Build Action - #287

Open
tetj wants to merge 3 commits into
ITotalJustice:masterfrom
tetj:1.0.0
Open

Fixed GitHub Build Action#287
tetj wants to merge 3 commits into
ITotalJustice:masterfrom
tetj:1.0.0

Conversation

@tetj

@tetj tetj commented Mar 24, 2026

Copy link
Copy Markdown

v1.0.0 would not compile without this fix but not sure this is the most appropriate fix

Here is the problem I had when compiling using GitHub Build Action :

The build is failing due to multiple definition errors for enums that are already defined in the libnx header files. The issue is in switch_usb.cpp which redefines enum usb_request_recipient and enum usb_request_type that already exist in /opt/devkitpro/libnx/include/switch/services/usb.h.

Root Cause
The switch_usb.cpp file is defining USB enums locally instead of using the ones provided by the libnx library headers. This causes duplicate definition errors during compilation.

Solution
Remove the enum definitions from switch_usb.cpp and rely on the libnx headers instead.

@tetj

tetj commented Mar 24, 2026

Copy link
Copy Markdown
Author

I tried to fix the compiling issues I had with GitHub Build Action. Now this branch/PR compiles but the app/nro does not work.

Anyway, I was able to make it worth 100% both when compiling it locally and when using GitHub Actions.
I'll create another PR for that version.

@tetj tetj changed the title 1.0.0 Fixed GitHub Build Action Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant