Fixed GitHub Build Action - #287
Open
tetj wants to merge 3 commits into
Open
Conversation
Author
|
I tried to fix the compiling issues I had with GitHub Build Action. Now this branch/PR compiles but the app/nro does not work. Anyway, I was able to make it worth 100% both when compiling it locally and when using GitHub Actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.0.0 would not compile without this fix but not sure this is the most appropriate fix
Here is the problem I had when compiling using GitHub Build Action :
The build is failing due to multiple definition errors for enums that are already defined in the libnx header files. The issue is in switch_usb.cpp which redefines enum usb_request_recipient and enum usb_request_type that already exist in /opt/devkitpro/libnx/include/switch/services/usb.h.
Root Cause
The switch_usb.cpp file is defining USB enums locally instead of using the ones provided by the libnx library headers. This causes duplicate definition errors during compilation.
Solution
Remove the enum definitions from switch_usb.cpp and rely on the libnx headers instead.