Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport a 1.10 implementation for LinearAlgebra.diagind #23

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Jan 22, 2025

This provides a simple backwards fix of the LTS implementation of eachstoredindex(::Diagonal).

See also ITensor/BlockSparseArrays.jl#32

@lkdvos lkdvos requested a review from mtfishman January 22, 2025 16:31
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (3d774aa) to head (02ba823).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wrappers.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   62.98%   62.54%   -0.45%     
==========================================
  Files           6        6              
  Lines         281      283       +2     
==========================================
  Hits          177      177              
- Misses        104      106       +2     
Flag Coverage Δ
docs 62.41% <0.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member

Looks like a reasonable fix to me, can you add back the corresponding tests that were marked as broken in #31?

@lkdvos
Copy link
Contributor Author

lkdvos commented Jan 22, 2025

Yes, but that is in BlockSparseArrays, so this needs to first get merged :)

@mtfishman
Copy link
Member

Yes, but that is in BlockSparseArrays, so this needs to first get merged :)

Ah, right, I wasn't paying attention haha.

@lkdvos lkdvos merged commit b41609b into ITensor:main Jan 22, 2025
9 of 11 checks passed
@lkdvos lkdvos deleted the fix-diagind branch January 22, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants