Improve the BilinearForm Constructor #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great to see this – very quick work. Hopefully it will mean that Antonio can try the purification now. |
mtfishman
reviewed
Apr 26, 2025
mtfishman
reviewed
Apr 26, 2025
mtfishman
reviewed
Apr 27, 2025
Co-authored-by: Matt Fishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
BilinearFormNetworkandQuadraticFormNetworkconstructors in the case an operator isn't explicitly passed and therefore the "identity" operator is assumed.The constructor can now handle vertices with multiple (or no) site indices per vertex, whereas previously it could only handle strictly one site index per vertex. Tests are added.
Additionally:
VidalITensorNetworkconstructor is fixed, where the cache was being updated even whenupdate_cache= falseis passed.EinExprs.jlHyPar tests are disabled due to the fact they no longer work.contraction_tree_to_graph.jlcode and tests has been removed as it is not being used anywhere in the library and I cannot envision any future use for it right now.@emstoudenmire @anmello this is the bug we discussed yesterday