Skip to content

CompatHelper: bump compat for SparseArraysBase to 0.4, (keep existing compat) #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2025

This pull request changes the compat entry for the SparseArraysBase package from 0.2.1, 0.3 to 0.2.1, 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.51%. Comparing base (3eb3a17) to head (50d2966).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/diagonalarray/diagonalarray.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   81.69%   80.51%   -1.18%     
==========================================
  Files          12       11       -1     
  Lines         153      154       +1     
==========================================
- Hits          125      124       -1     
- Misses         28       30       +2     
Flag Coverage Δ
docs 65.78% <33.33%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Member

I noticed that the constructors for DiagonalArray should be updated to match the new style and interfaces of SparseArrayDOK (ITensor/SparseArraysBase.jl#43) and BlockSparseArray (ITensor/BlockSparseArrays.jl#68), but I'll leave that for a future PR since that will be breaking.

@mtfishman mtfishman merged commit ccd35c2 into main Mar 7, 2025
11 of 13 checks passed
@mtfishman mtfishman deleted the compathelper/new_version/2025-03-07-01-22-04-406-03311859694 branch March 7, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant