-
Notifications
You must be signed in to change notification settings - Fork 2
Fix printing higher dimensional block sparse arrays #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/abstractblocksparsearray/wrappedabstractblocksparsearray.jl
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 75.46% 75.51% +0.04%
==========================================
Files 28 28
Lines 1072 1074 +2
==========================================
+ Hits 809 811 +2
Misses 263 263
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a clean fix to me. It might even make sense to keep that definition of isstored
for SubArray
, that does seem like how you would want to define that?
Are you suggesting defining it this way for any |
This is basically the same definition as |
I've moved the definition over to SparseArraysBase.jl, so this now relies on ITensor/SparseArraysBase.jl#44 getting merged and registered. |
Fixes #73.