Skip to content

Fix printing higher dimensional block sparse arrays #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Conversation

mtfishman
Copy link
Member

Fixes #73.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.51%. Comparing base (2b4ab96) to head (46aaa7b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   75.46%   75.51%   +0.04%     
==========================================
  Files          28       28              
  Lines        1072     1074       +2     
==========================================
+ Hits          809      811       +2     
  Misses        263      263              
Flag Coverage Δ
docs 16.36% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman requested review from lkdvos and ogauthe March 5, 2025 18:47
Copy link
Contributor

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean fix to me. It might even make sense to keep that definition of isstored for SubArray, that does seem like how you would want to define that?

@mtfishman
Copy link
Member Author

mtfishman commented Mar 5, 2025

Looks like a clean fix to me. It might even make sense to keep that definition of isstored for SubArray, that does seem like how you would want to define that?

Are you suggesting defining it this way for any SubArray (i.e. make a generic definition in SparseArraysBase.jl)?

@mtfishman
Copy link
Member Author

This is basically the same definition as getindex(::SubArray, I::Int...) and isassigned(::SubArray, I::Int...) so I guess this is a reasonable definition more generally.

@mtfishman
Copy link
Member Author

I've moved the definition over to SparseArraysBase.jl, so this now relies on ITensor/SparseArraysBase.jl#44 getting merged and registered.

@mtfishman mtfishman closed this Mar 6, 2025
@mtfishman mtfishman reopened this Mar 6, 2025
@mtfishman mtfishman merged commit f55f2dc into main Mar 6, 2025
17 of 28 checks passed
@mtfishman mtfishman deleted the high_dim_show branch March 6, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] display of 3D BlockSparseArray errors
2 participants