Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguities with BlockArrays.jl #39

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fix ambiguities with BlockArrays.jl #39

merged 4 commits into from
Feb 7, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 6, 2025

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (a7197ad) to head (84260df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   73.83%   73.93%   +0.09%     
==========================================
  Files          30       30              
  Lines        1051     1055       +4     
==========================================
+ Hits          776      780       +4     
  Misses        275      275              
Flag Coverage Δ
docs 26.10% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman
Copy link
Member Author

mtfishman commented Feb 6, 2025

@ogauthe @lkdvos it looks like JuliaArrays/BlockArrays.jl#445 caused some ambiguity errors that we will need to resolve (this PR was meant to fix other ones I found, but the CI run caught more, which I think are particular to the BlockArrays.jl v1.4.0 release).

@mtfishman
Copy link
Member Author

mtfishman commented Feb 6, 2025

Actual the issue probably originates in GradedUnitRanges.jl. EDIT: Fixing ITensor/GradedUnitRanges.jl#12.

@mtfishman
Copy link
Member Author

@lkdvos @ogauthe ready for review. Like @lkdvos pointed out in ITensor/GradedUnitRanges.jl#12, ideally we would use Aqua to preemptively catch these but there are too many ambiguities listed by Aqua right now so I think it is better to fix these examples and look into that in future PRs, probably it requires reassessing some of the code design in a deeper way.

@mtfishman mtfishman requested review from lkdvos and ogauthe February 6, 2025 20:40
@mtfishman mtfishman changed the title Fix ambiguities Fix ambiguities with BlockArrays.jl Feb 6, 2025
@mtfishman mtfishman merged commit 88aa06f into main Feb 7, 2025
12 checks passed
@mtfishman mtfishman deleted the fix_ambiguities branch February 7, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants