-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguities with BlockArrays.jl #39
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 73.83% 73.93% +0.09%
==========================================
Files 30 30
Lines 1051 1055 +4
==========================================
+ Hits 776 780 +4
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ogauthe @lkdvos it looks like JuliaArrays/BlockArrays.jl#445 caused some ambiguity errors that we will need to resolve (this PR was meant to fix other ones I found, but the CI run caught more, which I think are particular to the BlockArrays.jl v1.4.0 release). |
Actual the issue probably originates in GradedUnitRanges.jl. EDIT: Fixing ITensor/GradedUnitRanges.jl#12. |
@lkdvos @ogauthe ready for review. Like @lkdvos pointed out in ITensor/GradedUnitRanges.jl#12, ideally we would use Aqua to preemptively catch these but there are too many ambiguities listed by Aqua right now so I think it is better to fix these examples and look into that in future PRs, probably it requires reassessing some of the code design in a deeper way. |
Hit when working on ITensor/QuantumOperatorDefinitions.jl#22.