Skip to content

Fix accidental method overwrite of default_svd_algorithm #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mtfishman
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.68%. Comparing base (6bee699) to head (d373143).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/factorizations/svd.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6bee699) and HEAD (d373143). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (6bee699) HEAD (d373143)
6 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #130       +/-   ##
==========================================
- Coverage   74.15%   6.68%   -67.47%     
==========================================
  Files          34      33        -1     
  Lines        1706    1691       -15     
==========================================
- Hits         1265     113     -1152     
- Misses        441    1578     +1137     
Flag Coverage Δ
docs 6.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Member Author

Depends on QuantumKitHub/MatrixAlgebraKit.jl#32. This will get improved upon by #129 but I think it is worth fixing this smaller issue first.

@mtfishman
Copy link
Member Author

Fixed by #131.

@mtfishman mtfishman closed this Jun 4, 2025
@mtfishman mtfishman deleted the mf/fix_default_svd_alg_piracy branch June 4, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant