-
Notifications
You must be signed in to change notification settings - Fork 2
Add truncation functionality for SVD #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 72.22% 73.27% +1.05%
==========================================
Files 27 28 +1
Lines 1170 1216 +46
==========================================
+ Hits 845 891 +46
Misses 325 325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I added tests and functionality for I think this should be more or less ready for review, we have to decide how to select truncation strategies and how to make sure the correct blocked ones get selected. |
This is an initial implementation for truncated SVD for block(permuted)diagonal matrices.
Depends on #111