Skip to content

Add truncation functionality for SVD #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 9, 2025
Merged

Add truncation functionality for SVD #113

merged 13 commits into from
May 9, 2025

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented May 5, 2025

This is an initial implementation for truncated SVD for block(permuted)diagonal matrices.
Depends on #111

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (6c92d7c) to head (17ccf8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   72.22%   73.27%   +1.05%     
==========================================
  Files          27       28       +1     
  Lines        1170     1216      +46     
==========================================
+ Hits          845      891      +46     
  Misses        325      325              
Flag Coverage Δ
docs 12.30% <0.00%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from matrixalgebrakit to main May 6, 2025 20:28
@lkdvos lkdvos marked this pull request as ready for review May 8, 2025 18:17
@lkdvos
Copy link
Contributor Author

lkdvos commented May 8, 2025

I added tests and functionality for trunctol as well, success of the tests depends on ITensor/SparseArraysBase.jl#58

I think this should be more or less ready for review, we have to decide how to select truncation strategies and how to make sure the correct blocked ones get selected.

@lkdvos lkdvos requested a review from mtfishman May 8, 2025 18:52
@lkdvos lkdvos merged commit 9eb742b into main May 9, 2025
19 of 25 checks passed
@lkdvos lkdvos deleted the truncation branch May 9, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants