Fix: A11y radiobutton keyboard navigation/VO#1552
Merged
Merged
Conversation
NovaCat35
requested review from
emilygorelik and
esteinborn
and removed request for
esteinborn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 2/3 of the a11y issues with
nys-radiogroup/button. Not perfect, will need a major restructuring of the component in a later ticket.left/rightkey event doesn't move the focus state and doesn't select withenter/spaceNOTE: This PR is meant as a bandaid PR, before the restructuring ticket found on #1553 🎟️
Breaking change
This is not a breaking change.
Related issues
Closes #1544 🎟️