♻️✨ ViP Store: Licensed Item model and Cache #7261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
…simcore into enh/licensed-item-model
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
dyollb,
pcrespov,
sanderegg and
matusdrobuliak66
|
matusdrobuliak66
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As suggested by @dyollb in #7249 (comment), this PR implements the LicensedItem and its LicensedItemResource data models to reduce the number of places where magic strings are used. Both models are also cached.
(accidentally includes #7258)
Related issue/s
How to test
Dev-ops checklist