Skip to content

🎨 Palette: Improve navigation accessibility and semantics - #57

Open
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-17254429327339929005
Open

🎨 Palette: Improve navigation accessibility and semantics#57
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-17254429327339929005

Conversation

@ISTEC-FOR340

Copy link
Copy Markdown
Owner

This PR improves the accessibility and semantic structure of the Interactive Sketches project.

πŸ’‘ What: The UX enhancement added

  • Replaced JavaScript-driven div navigation with semantic <a> tags for all main project cards and "Back" buttons.
  • Updated the HTML lang attribute to correctly reflect the English content.
  • Added explicit :focus-visible styles to provide clear visual feedback for keyboard users, matching the existing hover animations.
  • Cleaned up obsolete routing logic in script.js.

🎯 Why: The user problem it solves

  • JavaScript-only navigation is inaccessible to screen readers and prevents standard browser features like "Open in new tab".
  • Missing focus indicators made the site difficult to navigate via keyboard.
  • Incorrect lang attribute could confuse assistive technologies.

β™Ώ Accessibility: Any a11y improvements made

  • Semantic HTML: Navigation now uses proper link tags.
  • Keyboard Nav: Users can now clearly see which element is focused when tabbing.
  • Language: Corrected document language metadata.
  • Valid Nesting: Removed interactive elements from inside links to prevent focus traps.

PR created automatically by Jules for task 17254429327339929005 started by @ISTEC-FOR340

- Convert landing page cards from `div` to semantic `<a>` tags.
- Convert nested `<button>` elements to `<span>` to avoid invalid nested interactive elements.
- Convert sub-project "Back" buttons to semantic `<a>` links.
- Update `lang="es"` to `lang="en"` in `index.html` to match content.
- Implement `:focus-visible` styles mirroring hover effects for better keyboard navigation.
- Remove redundant manual navigation logic from `script.js`.

Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant