Skip to content

🎨 Palette: Semantic and accessible navigation - #48

Open
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-4085075305909633334
Open

🎨 Palette: Semantic and accessible navigation#48
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-4085075305909633334

Conversation

@ISTEC-FOR340

Copy link
Copy Markdown
Owner

🎨 Palette: Semantic and accessible navigation

πŸ’‘ What

Refactored the project's navigation system to use semantic HTML <a> tags instead of JavaScript onclick handlers on div and button elements.

🎯 Why

The previous implementation was inaccessible to keyboard users and screen readers, and it broke standard browser features like "Open in new tab". By using semantic links, we improve accessibility, SEO, and the overall robustness of the application.

β™Ώ Accessibility

  • Semantic Links: Used <a> tags for all navigation elements.
  • Focus States: Added high-contrast :focus-visible rings to cards and buttons to ensure clear visual feedback during keyboard navigation.
  • Valid HTML: Converted nested buttons to spans within link cards to avoid invalid nested interactive elements.
  • Language Metadata: Ensured lang="es" is set across all pages for consistency with the ISTEC educational target audience.

βœ… Verification

  • Verified keyboard navigation (Tab and Enter) using Playwright.
  • Confirmed focus indicators are visible and follow the design system.
  • Deleted script.js as it is no longer required for navigation.

PR created automatically by Jules for task 4085075305909633334 started by @ISTEC-FOR340

- Convert landing page cards from `div` to `<a>` tags.
- Convert subproject "Back" buttons from `button` to `<a>` tags.
- Remove redundant navigation logic in `script.js`.
- Add `:focus-visible` styles for better keyboard accessibility.
- Set consistent `lang="es"` for ISTEC educational context.

Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant