π¨ Palette: Semantic navigation and keyboard accessibility - #43
π¨ Palette: Semantic navigation and keyboard accessibility#43ISTEC-FOR340 wants to merge 1 commit into
Conversation
Refactored landing page cards and project back-buttons from non-semantic div/button elements with JavaScript listeners to semantic <a> tags. Key improvements: - Enabled native browser features (middle-click, right-click menu, URL preview). - Improved accessibility by ensuring screen readers identify links correctly. - Added explicit :focus-visible styles for better keyboard navigation. - Removed redundant JavaScript navigation logic and cleaned up unused script files. - Ensured valid HTML by converting nested buttons into spans within link cards. Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What
Refactored the navigation system to use semantic
<a>tags instead ofdivelements withonclickhandlers. Updated the CSS to include robust:focus-visiblestates and ensured that visual feedback on keyboard focus matches the hover experience.π― Why
The previous implementation relied on JavaScript for basic navigation, which broke standard browser behaviors (like opening in new tabs) and made the site less accessible to screen reader and keyboard users. Using semantic HTML is a fundamental UX improvement that "just works" as users expect.
βΏ Accessibility
divandbuttonwith<a>for navigation.:focus-visiblerings to interactive cards.<button>elements to<span>to avoid interactive element nesting errors.PR created automatically by Jules for task 12907940139987370813 started by @ISTEC-FOR340