Skip to content

🎨 Palette: Semantic navigation and keyboard accessibility - #43

Open
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-12907940139987370813
Open

🎨 Palette: Semantic navigation and keyboard accessibility#43
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-12907940139987370813

Conversation

@ISTEC-FOR340

Copy link
Copy Markdown
Owner

πŸ’‘ What

Refactored the navigation system to use semantic <a> tags instead of div elements with onclick handlers. Updated the CSS to include robust :focus-visible states and ensured that visual feedback on keyboard focus matches the hover experience.

🎯 Why

The previous implementation relied on JavaScript for basic navigation, which broke standard browser behaviors (like opening in new tabs) and made the site less accessible to screen reader and keyboard users. Using semantic HTML is a fundamental UX improvement that "just works" as users expect.

β™Ώ Accessibility

  • Semantic HTML: Replaced div and button with <a> for navigation.
  • Focus Indicators: Added high-contrast :focus-visible rings to interactive cards.
  • Valid Nesting: Converted nested <button> elements to <span> to avoid interactive element nesting errors.
  • Keyboard Nav: Users can now navigate the entire site using only the keyboard with clear visual feedback.

PR created automatically by Jules for task 12907940139987370813 started by @ISTEC-FOR340

Refactored landing page cards and project back-buttons from non-semantic div/button elements with JavaScript listeners to semantic <a> tags.

Key improvements:
- Enabled native browser features (middle-click, right-click menu, URL preview).
- Improved accessibility by ensuring screen readers identify links correctly.
- Added explicit :focus-visible styles for better keyboard navigation.
- Removed redundant JavaScript navigation logic and cleaned up unused script files.
- Ensured valid HTML by converting nested buttons into spans within link cards.

Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant