Skip to content

🎨 Palette: Improve navigation semantics and accessibility - #39

Open
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-9003686727488988308
Open

🎨 Palette: Improve navigation semantics and accessibility#39
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette-semantic-navigation-9003686727488988308

Conversation

@ISTEC-FOR340

Copy link
Copy Markdown
Owner

🎨 Palette: Improve navigation semantics and accessibility

This PR enhances the usability and accessibility of the MySketches portfolio by aligning the navigation structure with semantic HTML standards.

πŸ’‘ What:

  • Semantic Links: Converted div.card elements and back-btn buttons to standard <a> tags.
  • Accessibility Fixes: Set lang="en" on all pages to ensure correct screen reader interpretation.
  • Keyboard Navigation: Implemented explicit :focus-visible styles that mimic the hover effects (transforms and shadows) and added a high-contrast focus ring for better visibility.
  • Cleanup: Removed the manual script.js navigation logic, simplifying the codebase and leveraging native browser behavior.

🎯 Why:

The original implementation used onclick handlers on div elements, which are not natively keyboard-accessible and don't support standard link features (like opening in a new tab). These changes make the portfolio fully navigable by keyboard and screen readers while maintaining the original sleek design.

β™Ώ Accessibility:

  • Corrected language declaration.
  • Removed nested interactive elements (buttons inside links).
  • Added visible focus indicators.
  • Used semantic tags for navigation.

All changes are surgical and keep the repository clean of verification artifacts.


PR created automatically by Jules for task 9003686727488988308 started by @ISTEC-FOR340

- Refactored project cards in index.html to semantic <a> tags.
- Converted "Back" buttons in subprojects to semantic <a> tags.
- Corrected HTML lang attribute to "en" for better screen reader support.
- Added explicit :focus-visible styles to cards and back buttons.
- Removed dead script.js file used for manual navigation.
- Ensured all changes are surgical and minimize diff noise.

Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant