Skip to content

🎨 Palette: Semantic navigation and high-contrast focus indicators - #38

Open
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette/semantic-nav-focus-rings-17937680064201418863
Open

🎨 Palette: Semantic navigation and high-contrast focus indicators#38
ISTEC-FOR340 wants to merge 1 commit into
mainfrom
palette/semantic-nav-focus-rings-17937680064201418863

Conversation

@ISTEC-FOR340

Copy link
Copy Markdown
Owner

πŸ’‘ What: The UX enhancement added

Refactored the navigation system on the landing page and subprojects.

  • Converted non-semantic div cards and manual button back-links to semantic <a> tags.
  • Implemented custom :focus-visible styles with a high-contrast double-ring effect.
  • Optimized card CSS to use overflow: visible combined with pseudo-elements for backgrounds, ensuring that keyboard focus indicators are never clipped by the container boundaries.
  • Removed script.js as native browser navigation now handles all routing.

🎯 Why: The user problem it solves

The previous implementation relied on JavaScript onclick handlers on non-interactive div elements. This prevented standard browser features like "Open in new tab", hindered SEO, and made keyboard navigation impossible without custom logic. Additionally, the dark glassmorphism theme lacked visible focus indicators, making the site difficult to navigate for keyboard-only users.

β™Ώ Accessibility: Any a11y improvements made

  • Semantic HTML: Replaced generic containers with appropriate interactive elements (<a>).
  • Keyboard Navigation: Native tab order is now supported, and interactive elements have highly visible focus states.
  • Invalid Nesting: Removed nested buttons inside card links to comply with ARIA and HTML standards.
  • Visual Feedback: Focus rings are high-contrast and unclipped, providing clear feedback during navigation.

PR created automatically by Jules for task 17937680064201418863 started by @ISTEC-FOR340

- Refactored non-semantic `div` and `button` navigation to `<a>` tags.
- Implemented high-contrast `:focus-visible` rings with `box-shadow`.
- Adjusted CSS (`overflow: visible` and `::after`) to prevent focus ring clipping.
- Removed redundant `script.js` navigation logic.

Co-authored-by: ISTEC-FOR340 <269002038+ISTEC-FOR340@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant