Ticket8814: Added logic to respect .zip backup when present #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| backup_zip_file = os.path.join(path_to_backup + ".zip") | ||
| if os.path.exists(backup_zip_file): | ||
| #Extract the file name without extension. | ||
| backup_file_name = os.path.basename(path_to_backup) |
Check notice
Code scanning / CodeQL
Unused local variable Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the problem in installation_and_upgrade/ibex_install_utils/tasks/backup_tasks.py, the assignment to backup_file_name on line 120 should be removed, since the variable is never used and its assignment has no side effects. Specifically, delete or comment out line 120, ensuring that the code block remains syntactically correct and that no required operations are lost. No imports or additional definitions are needed.
Suggested changeset
1
installation_and_upgrade/ibex_install_utils/tasks/backup_tasks.py
| @@ -117,7 +117,6 @@ | ||
| backup_zip_file = os.path.join(path_to_backup + ".zip") | ||
| if os.path.exists(backup_zip_file): | ||
| #Extract the file name without extension. | ||
| backup_file_name = os.path.basename(path_to_backup) | ||
| with zipfile.ZipFile(backup_zip_file, 'r') as backup_ref: | ||
| if not file_to_check in backup_ref.namelist(): | ||
| backup_zip_exists = False |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deployment issue reported here.