Add OPI for MAPS Vacuum OPC PLC #1787
Open
+3,868
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| @@ -4019,6 +4019,24 @@ | |||
| </macros> | |||
| <categories/> | |||
| </value> | |||
| </entry> | |||
| <entry> | |||
| <key>MAPS-OPC-Server</key> | |||
There was a problem hiding this comment.
Would MAPS Vacuum System or similar be less ambiguous (in case MAPS happen to get other, non-vacuum, OPC things in future)?
There was a problem hiding this comment.
Yes not a bad idea! I think I ran out of creativity for names on this one hahha.
change name of OPI that gets linked, to make more clear what it is
Change references to MAPS_OPC_TPG.opi for linking containers, and rename file to make more clear
Change references to OPI, and key value to be more specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
OPI to display two TPG300 values for MAPS Vacuum System
Ticket
Acceptance criteria
MAPS-OPC-Server. You should be able to change the units, and the graph should update. There should not be any other writeable PVs on the OPI as per Sunil's requirements to limit TPG and Vacuum safety protocols.List the acceptance criteria for the PR. The aim is provide information to help the reviewer
Unit tests
Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer
System tests
Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps