Skip to content

Ticket6240 3he fridge cryo logic #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2022
Merged

Conversation

JamesKingWork
Copy link
Contributor

Description of work

Correct OPI to fit newly implemented recondense logic.

Ticket

ISISComputingGroup/IBEX#6240

Acceptance criteria

List the acceptance criteria for the PR. The aim is provide information to help the reviewer

Unit tests

Give an overview of unit tests you have added or modified, if applicable. The aim is provide information to help the reviewer

System tests

Mention any automated tests or manual tests that you have added or modified, if applicable. The aim is provide information to help the reviewer

Documentation

Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Is there associated PR for the release notes?

Final Steps

@rerpha rerpha merged commit 0944a4f into master May 6, 2022
@rerpha rerpha deleted the Ticket6240_3He_Fridge_Cryo_Logic branch May 6, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants