Set uncertainties more correctly #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids broadcasting the addition across many tof channels/pixels
rerpha
reviewed
Mar 31, 2025
rerpha
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid normalization should crash a scan - there's really no way around this, we should not "pretend" to be able to do it. Have checked with scientists that this makes sense to them and they agreed an exception is better than giving "some" data which would be meaningless. In real life, monitor counts being zero means something is fundamentally wrong with the beamline (shutter closed, monitor not in, etc) so the scan can never really be valid in that state.
Also move the variance addition later - after summing all the detectors - basically do it at the last level possible when our units are still "counts". This avoids broadcasting the "extra" variance across multiple tof channels / pixels.