Ticket42 sum detect monitor spectra #66
Conversation
esmith1729
commented
Nov 19, 2024
esmith1729
commented
- Sum detector/monitor spectra with tof/wavelength bounds #42
…default monitor and detector summers to sum_spectra
…f bound and wavelength bounding of spectra
…ter for tof_bounded_spectra and wavelength_bounded_spectra
doc/devices/dae.md
Outdated
| {py:obj}`ibex_bluesky_core.devices.simpledae.reducers.tof_bounded_spectra` | ||
|
|
||
|
|
||
| Monitor Normalizers, which have both a monitor as well as detector, can be passed a summing function for each of these components independently, e.g. the detector can use time of flight while the monitor uses wavelength. Here is an example with wavelength bounding used to sum the monitor component, and time of flight bounding for the detector summing spectra: |
There was a problem hiding this comment.
should: somewhere we need to explain that while you can use different flight path lengths for detectors & monitors, there is an assumption that the flight path length is the same for all detector pixels. This will usually be true for the kinds of detector pixels that are regularly scanned over.
(We could in future allow a length-per-pixel, but not as part of this ticket)
There was a problem hiding this comment.
I'm not quite sure where is the best place to put this, or how best to explain it in a way the user would understand. I can give it a shot though.
There was a problem hiding this comment.
How about something like:
tof_bounded_spectraassumes that all pixels being summed share the same flight-path length. Where two separate instances oftof_bounded_spectraare used, such as inDetectorMonitorNormaliser, these may have different flight path lengths from each other.
In either the docstring of the method, or the top level docs - whichever you choose.
There was a problem hiding this comment.
Sounds good, thank you very much!
…h bounds not equal to 2.
add local variable bounds_value to compare number of bounds, and rephrasing some API reference explanation.
