Beckhoff: log less

[Tom-Willemsen]

IMAT filled up their disk with 10+GB of messages in <24h of the form:

[2023-02-14 23:59:59] 2023/02/14 23:59:58.391 [ERROR] C:\Instrument\Apps\EPICS\support\adsDriver\master\adsApp\src\ADSPortDriver.cpp:747 integerRead(): [ads-port] Read failed(1010): data could not be read

after a plc code change.

Acceptance criteria:

• The beckhoff driver does not log unreasonable amounts after a plc change on the controller, or on disconnection from the hardware.

[rerpha]

consider adding a last error code to https://github.com/ISISComputingGroup/adsDriver/blob/main/adsApp/src/ADSPortDriver.cpp#L745 and only log if its a new code

[rerpha]

we should probably make a PR upstream for this too, i suspect cosylab will want it

[rerpha]

I am going to submit two separate PRs upstream.

1. Make the sum-read rate configurable from AdsOpen() ioc command - done (add way of specifying sum read period Cosylab/adsDriver#5)
2. Add another ioc command option to not print loads if the same status has occurred (spun out to Beckhoff: do not fill logs when PLC is disconnected #8406)

once these are approved i will merge in upstream and update our st-common to utilise the new command args

[rerpha]

ISISComputingGroup/EPICS-ioc#866
ISISComputingGroup/adsDriver#4
#8405

[rerpha]

potentially linked to #8339

[Tom-Willemsen]

The linked changes slow down the logging rate when disconnected to ~330MB/day (rather than 10GB). Further improvements in #8406