Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beckhoff: do not fill logs when PLC is disconnected #8406

Open
1 task
rerpha opened this issue Jun 28, 2024 · 1 comment · May be fixed by ISISComputingGroup/adsDriver#5 or #8544
Open
1 task

Beckhoff: do not fill logs when PLC is disconnected #8406

rerpha opened this issue Jun 28, 2024 · 1 comment · May be fixed by ISISComputingGroup/adsDriver#5 or #8544
Assignees

Comments

@rerpha
Copy link
Contributor

rerpha commented Jun 28, 2024

As a developer I would like the TC IOC to not log as much when the error message is the same. disk space usage was improved with #7618 but I would like adsDriver to be more clever about sum read failures etc. when it cannot read a variable suddenly (this may be the case of a beckhoff which suddenly fails to communicate, but not on startup)

acceptance criteria

  • AdsDriver is modified to recognise when it is printing the same error lots of times and just truncates the messages by saying something like "this error happened x times" on an interval

note we already do this somewhere i think? or perhaps it's an option in asyn. might be worth doing some research to see existing solutions.

@rerpha rerpha mentioned this issue Jun 28, 2024
1 task
@rerpha
Copy link
Contributor Author

rerpha commented Sep 18, 2024

THis may be needed for IMAT's upgrade as one of the options for the pendant is to kill comms to ibex when the pendant is in use. I need to test with IDD and see what actually happens when it comes back up, but i suspect RBVs will be updated straight away.

@rerpha rerpha removed this from PI_2024_08 Sep 18, 2024
@rerpha rerpha changed the title Beckhoff: log even lesser Beckhoff: do not fill logs when PLC is disconnected Sep 18, 2024
@KathrynBaker KathrynBaker moved this to Backlog in PI_2024_08 Oct 4, 2024
@esmith1729 esmith1729 self-assigned this Oct 10, 2024
@esmith1729 esmith1729 moved this from Backlog to In Progress in PI_2024_08 Oct 10, 2024
@esmith1729 esmith1729 linked a pull request Oct 10, 2024 that will close this issue
@esmith1729 esmith1729 linked a pull request Oct 10, 2024 that will close this issue
esmith1729 added a commit that referenced this issue Oct 21, 2024
@esmith1729 esmith1729 linked a pull request Oct 21, 2024 that will close this issue
@esmith1729 esmith1729 linked a pull request Oct 21, 2024 that will close this issue
@davidkeymer davidkeymer moved this from Review to Backlog in PI_2024_08 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

5 participants