Skip to content

fix bugs in qwen3vl cp #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ISEEKYAN merged 1 commit into from
Jan 30, 2026
Merged

fix bugs in qwen3vl cp #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mbridge/models/qwen3_vl/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ def forward(
tp_rank=mpu.get_tensor_model_parallel_rank(),
cp_size=cp_size,
cp_rank=mpu.get_context_parallel_rank(),
sequence_parallel=self.config.sequence_parallel,
)
elif self.config.sequence_parallel: # THD and SP
visual_pos_masks, deepstack_visual_embeds = split_deepstack_embs(
Expand All @@ -403,6 +404,7 @@ def forward(
tp_rank=mpu.get_tensor_model_parallel_rank(),
cp_size=1,
cp_rank=0,
sequence_parallel=self.config.sequence_parallel,
)

if position_ids is None:
Expand Down
4 changes: 4 additions & 0 deletions mbridge/models/qwen3_vl/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,11 @@ def split_deepstack_embs(
tp_rank: int = 0,
cp_size: int = 1,
cp_rank: int = 0,
sequence_parallel: bool = True,
):
if not sequence_parallel:
tp_size = 1
tp_rank = 0
split_size = tp_size
if cp_size > 1:
split_size *= cp_size * 2
Expand Down
Loading