You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Thaurun@ISEEKYAN I noticed that this commit breaks saving at least for Deepseek:
There is a race condition, we should have a torch.distributed.barrier() right after the assertion that the huggingface folder doesn't contain safetensor files.
I also observed on other issue where w_files[0][4] is None, causing TypeError: '>' not supported between instances of 'NoneType' and 'int'
I think this happens because tensor_model_parallel can be None for some weights because export_weights_without_gather returns that, which is then stored in the tuple as None.
@Thaurun@ISEEKYAN I noticed that this commit breaks saving at least for Deepseek: There is a race condition, we should have a torch.distributed.barrier() right after the assertion that the huggingface folder doesn't contain safetensor files. I also observed on other issue where w_files[0][4] is None, causing TypeError: '>' not supported between instances of 'NoneType' and 'int' I think this happens because tensor_model_parallel can be None for some weights because export_weights_without_gather returns that, which is then stored in the tuple as None.
Thanks @jthomy for pointing out this issue, this has been fixed in #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new method can avoid gather, thereby saving additional GPU memory overhead.