replace HashMap with ConcurrentHashMap and use byte[]#4
Open
elijah-wright wants to merge 1 commit intoIRS-Public:mainfrom
Open
replace HashMap with ConcurrentHashMap and use byte[]#4elijah-wright wants to merge 1 commit intoIRS-Public:mainfrom
elijah-wright wants to merge 1 commit intoIRS-Public:mainfrom
Conversation
elijah-wright
force-pushed
the
memory-concurrency
branch
from
f3bedd3 to
f40ced4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR uses
ConcurrentHashMapinstead ofHashMapand removes the stream logic inread()inMemoryIOLocation. the synchronized block locks the object, meaning that multiple threads can't access the hash map.InputStreamis stateful, so I changed theread()function to directly get what is in the hash map